search

JuliaImages / Images.jl

An image library for Julia
http://juliaimages.org/
Other
535 stars 143 forks source link

Implementation for hough circle #602

Open hari-sikchi opened 7 years ago

hari-sikchi commented 7 years ago

I am looking to contribute to Julia Images and am looking for features to start with. I have noticed that Hough Circle implementation is yet to be done and geometric and clustering algorithms are not yet added. Should I start working on these features? Is there any plan to add geometric algorithms like triangulation in future?

timholy commented 7 years ago

Not yet, but see related material in https://github.com/JuliaImages/Images.jl/pull/601. Also, I don't know of anyone working on triangulation.

Perhaps neither of these should be added directly to Images itself, which is slowly becoming more of an "aggregator." Perhaps ImageFeatures for anything Hough-transform related, and ImageTransforms for triangulation? (@Evizero, what do you think?)

kmsquire commented 7 years ago

Triangulation probably fits more in with camera calibration (e.g., https://github.com/peterkovesi/ImageProjectiveGeometry.jl). Cc: @peterkovesi

timholy commented 7 years ago

I guess there are at least two kinds of triangulation. I assumed @hari-sikchi meant this kind, but I was just guessing.

Evizero commented 7 years ago

Good question. There is also https://github.com/dfdx/PiecewiseAffineTransforms.jl to consider.

kmsquire commented 7 years ago

@timholy, re: triangulation, makes sense, thanks!