search

JuliaImages / Images.jl

An image library for Julia
http://juliaimages.org/
Other
535 stars 143 forks source link

Port convexhull.jl and connected.jl to ImageMorphology.jl #807

Closed johnnychen94 closed 4 years ago

johnnychen94 commented 5 years ago

I propose to move the following two files to ImageMorphology.jl

My reason is: graphs are heavily used in morphology operations

ported functions:

All of these functions are exported by Images, but it would quite painless since ImageMorphology is reexported by Images

Possibly, labeledarrays.jl can be ported to ImageMorphology.jl as well.

cc: @juliohm, @aquatiko

juliohm commented 5 years ago

Thank you Johnny for proposing the move. I like the idea of moving anything from Images.jl to subpakcages, and these functions seem to fit well in ImageMorphology.jl

On Wed, May 15, 2019, 23:44 Johnny Chen notifications@github.com wrote:

I propose to move the following two files to ImageMorphology.jl

My reason is: graphs are heavily used in morphology operations

ported functions:

All of these functions are exported by Images, but it would quite painless since ImageMorphology is reexported by Images

Possibly, labeledarrays.jl https://github.com/JuliaImages/Images.jl/blob/master/src/labeledarrays.jl can be ported to ImageMorphology.jl as well.

cc: @juliohm https://github.com/juliohm, @aquatiko https://github.com/aquatiko

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaImages/Images.jl/issues/807?email_source=notifications&email_token=AAZQW3O37TBC4MCMHVUZ2RTPVTC7HA5CNFSM4HNIOZ42YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUCAMXQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZQW3KKW7DRDDADJVBJHJTPVTC7HANCNFSM4HNIOZ4Q .