JuliaImages / QRCoders.jl

Creating QR Codes within Julia
https://juliaimages.org/QRCoders.jl/
MIT License
67 stars 11 forks source link

add operation for Polynomials and GF intergers #15

Closed RexWzh closed 1 year ago

RexWzh commented 1 year ago

operations for polynomials and GF intergers

  1. src/errorcorrection.jl
    • divide: division of GF intergers
    • ÷, % operation for polynomials
  2. test/tst_operations.jl: test for divide, ÷, %
codecov[bot] commented 1 year ago

Codecov Report

Merging #15 (3a7a566) into master (492ec75) will increase coverage by 0.30%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   96.57%   96.88%   +0.30%     
==========================================
  Files           3        3              
  Lines         292      321      +29     
==========================================
+ Hits          282      311      +29     
  Misses         10       10              
Impacted Files Coverage Δ
src/QRCoders.jl 98.42% <100.00%> (ø)
src/errorcorrection.jl 91.66% <100.00%> (+5.62%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

johnnychen94 commented 1 year ago

@RexWzh can you also work the rename stuff (QRCode => QRCodes or QRCoders) of this package before making a release? https://github.com/JuliaImages/QRCode.jl/pull/9#issuecomment-1113939138

RexWzh commented 1 year ago

Get. Changes are as following:

  1. filename: src/QRCode.jl => src/QRCoders.jl
  2. sourcecode, docs: QRCode => QRCoders
  3. Project.toml: QRCode => QRCoders

Questions about package development:

johnnychen94 commented 1 year ago

Okay, I've renamed this repo to QRCoders and created an archived fork version https://github.com/JuliaImages/QRCode.jl for legacy usage. Now we can simply treat it as a new package and reset the version to 0.1.0. We'll need a new UUID as well.

We can merge this PR and do the rename work in another PR.

cc: @jiegillet