JuliaImages / QRCoders.jl

Creating QR Codes within Julia
https://juliaimages.org/QRCoders.jl/
MIT License
67 stars 11 forks source link

Circular dependency when calling Decoder from Coder #42

Closed RexWzh closed 1 year ago

RexWzh commented 1 year ago

To plot images using free bits, one can use error correction to make it simpler and faster. However, using QRDecoders: fillerasures would cause package warning:

Warning: Circular dependency detected. Precompilation skipped for QRCoders

Notes from discourse

Circular dependencies may confuse a few scripts people write if they don’t take into account the possibility they might happen, but Pkg doesn’t have any problems with them. It might hit some corner cases in precompilation, hard to tell unless anyone finds an issue.

and suggestions

Unite into single module or move common functionality in a third module C. A circular dependency should more often than not viewed as a design flaw more than an issue to be handled explicitly.

~~I think it might be better to remove part of the file src/style.jl from QRCoders.jl into an individual package. Like BadApples.jl for Image-QRcodes.~~