JuliaImages / QRCoders.jl

Creating QR Codes within Julia
https://juliaimages.org/QRCoders.jl/
MIT License
67 stars 11 forks source link

fix encoding table for alphanumeric #9

Closed mfalt closed 2 years ago

mfalt commented 2 years ago

Pretty sure this is the correct order

johnnychen94 commented 2 years ago

Thanks for submitting this PR. This package was created by @jiegillet who is not using Julia anymore, which is why I asked him to move it to JuliaImages last winter. Revisiting and refreshing this package on top of JuliaImages ecosystem is planned as a part of the OSPP (GSoC-like) project. https://julialang.org/jsoc/gsoc/images/#better_qr_code_support_open_ended

There's a potential student on this project, I'll check this out with him by then.

johnnychen94 commented 2 years ago

That said, if you are confident about the QR codes details and if you want to maintain and improve this package, I can send you an invitation.

mfalt commented 2 years ago

Hi, sorry about not being more informative in my PR, I assume that whoever was responsible for the repo would be able to easily verify it. Thanks for taking care of the repo @johnnychen94! I noticed that the google lense app wasn't able to read the QRcodes generated here correctly. I found the same table as @jiegillet and changed the code accordingly, but I couldn't find a more authoritative source. However, the apps I tried works correctly with this fix so it should be fine to merge.

johnnychen94 commented 2 years ago

I need to set up CI first before merging this PR; I'll see if I can manage to do it this weekend. I've added this PR to my todo-list but still feel free to ping me if I forget about it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #9 (ec47247) into master (ec47247) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ec47247 differs from pull request most recent head 189b2e1. Consider uploading reports for the commit 189b2e1 to get more accurate results

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files           3        3           
  Lines         292      292           
=======================================
  Hits          282      282           
  Misses         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec47247...189b2e1. Read the comment docs.

johnnychen94 commented 2 years ago

I'll tag a new minor release for this because the Julia compatibility lower bound has changed from 1.0 to 1.3. It will be very likely to be the last minor release.

In the future, we'll rename this package to QRCodes.jl to introduce the type QRCode for dispatch purposes (#8). The QR decode is a part of the OSPP project and will be added here as well.