search

JuliaImages / juliaimages.github.io

Documentation For JuliaImages
https://juliaimages.org
33 stars 55 forks source link

Histogram Matching demo #178

Closed ashwani-rathee closed 3 years ago

ashwani-rathee commented 3 years ago

Demo for histogram matching has been added with this #164

Needs review

closes #165

ashwani-rathee commented 3 years ago

Plots should be included in Project.toml with an appropriate compat.

@johnnychen94 Hey,how can i do that? The last time I did something similiar,I used below command for project.toml generation "Pkg.generate("MusicProcessing")" #5

johnnychen94 commented 3 years ago

You could do it by activating the current project and adding it:

$ julia --project=.

pkg> add Plots

and then manually modifying Project.toml to add a compat entry for Plots( Plots = [1], maybe).

ashwani-rathee commented 3 years ago

little confused about where to add the chelsea.png in src/assets? or in democards/examples/covers

johnnychen94 commented 3 years ago

In a relative directory assets/chelsea.png and it's generated in runtime. You can take a look at other examples, e.g., https://github.com/JuliaImages/juliaimages.github.io/blob/18356b56e102c4b7d97cfbf3f9947536244a1c4a/docs/examples/image_quality_and_benchmarks/structural_similarity_index.jl#L46

ashwani-rathee commented 3 years ago

This adds plots and cover properly,should I combine the graphs together?

johnnychen94 commented 3 years ago

Similar to #183, I do think this demo can be written in a more concise while still informative way. There will be many new users looking at the demo so I hope they can be polished into some kind of "standard" form. I'll wait for a few more days so that you get more time to think about it.

ashwani-rathee commented 3 years ago

@johnnychen94 I did try to update by looking at canny rework and shortening the graph code by creating array,list,loop usage. Also updated the language used as I show in canny rework.Though I am not sure what a standard demo is supposed to look like :)

johnnychen94 commented 3 years ago

Curious to ask, have you ever tried out the partial build functionality of DemoCards?

julia> using DemoCards

julia> preview_demos("docs/examples/spatial_transformation/histogram_matching.jl")

If you haven't, then I'd recommend you to try this out because it significantly reduces the building time.

ashwani-rathee commented 3 years ago

Actually,I have.It's pretty good at what it's supposed to do,though it did confused me as it directs to index.html and not the demo directly.