JuliaImages / juliaimages.github.io

Documentation For JuliaImages
https://juliaimages.org
33 stars 55 forks source link

broken demo: "Cropping, Resizing and Rescaling" #182

Closed johnnychen94 closed 3 years ago

johnnychen94 commented 3 years ago

I don't see any code results and a cover is missing for demo: Cropping, Resizing and Rescaling, @ashwani-rathee could you please help fix this?

ashwani-rathee commented 3 years ago

@johnnychen94 Sure,though I did test it before pushing it online...can you tell what could be the issue?

johnnychen94 commented 3 years ago

According to the CI log(e.g., https://github.com/JuliaImages/juliaimages.github.io/runs/2118016729), it seems that we need to add ImageTransformations to Project.toml.

┌ Warning: LoadError: ArgumentError: Package ImageTransformations not found in current path:
│ - Run `import Pkg; Pkg.add("ImageTransformations")` to install the ImageTransformations package.
│ 
│ in expression starting at string:1
│ when executing the following code block
│ 
│ ```julia
│ using Images, ImageTransformations, TestImages, OffsetArrays
│ # load an example image
│ img_source = testimage("lighthouse")
│ ```
└ @ DemoCards ~/.julia/packages/DemoCards/oBsQD/src/types/julia.jl:174
┌ Warning: cover file doesn't exists
│   cover_path = "/home/runner/work/juliaimages.github.io/juliaimages.github.io/docs/examples/spatial_transformation/assets/lighthouse.png"
└ @ DemoCards ~/.julia/packages/DemoCards/oBsQD/src/generate.jl:329
johnnychen94 commented 3 years ago

though I did test it before pushing it online...

This happens when you have ImageTransformations installed in your root project. When a package is not specified in Project.toml (or more correctly, in Manifest.toml) of the project folder, julia will try to find and load it in DEPOT_PATH order:

julia> DEPOT_PATH
3-element Vector{String}:
 "/Users/jc/.julia"
 "/Applications/Julia-1.6.app/Contents/Resources/julia/local/share/julia"
 "/Applications/Julia-1.6.app/Contents/Resources/julia/share/julia"

In my case, Julia will finds this package in /Users/jc/.julia/environments/v1.6/Manifest.toml. However, every build in CI is a clean setup, so Julia complains about it.

ashwani-rathee commented 3 years ago

@johnnychen94 Okay,I'll just update it with ImageTransformations addititon,Should I create another PR for that or can the merged PR can be reverted and opened again?

johnnychen94 commented 3 years ago

When a PR is merged, it can only be reverted. So yeah please create a new PR.