JuliaInterop / Clang.jl

C binding generator and Julia interface to libclang
https://juliainterop.github.io/Clang.jl/
MIT License
219 stars 68 forks source link

`detect_headers`: sort headers list #421

Closed t-bltg closed 1 year ago

t-bltg commented 1 year ago

Fix https://github.com/Gnimuc/ClangCompiler.jl/issues/24.

Gnimuc commented 1 year ago

If Julia's Set is not deterministic between versions, then it's not a problem of Clang. I'd like to keep the dependency graph minimal.

t-bltg commented 1 year ago

No, it's non-deterministic for a single julia version:

$ julia generator.jl 1.9
$ julia generator.jl 1.9  # re-run, signatures changed

How about using a Vector and use unique! afterwards ? Or use sort ?

Gnimuc commented 1 year ago

Is it same with 1.8?

Gnimuc commented 1 year ago

How about using a Vector and use unique! afterwards ? Or use sort ?

yes, this is a good idea.