search

JuliaInterop / Clang.jl

C binding generator and Julia interface to libclang
https://juliainterop.github.io/Clang.jl/
MIT License
219 stars 68 forks source link

Cleanup CXFile support and add unique_id #424

Closed habemus-papadum closed 5 months ago

habemus-papadum commented 1 year ago

This is somewhat invasive, but hopefully not too scary.

It will help for adding support for modules which are uniqued by their ast file. I included the commit from #423 which is pretty simple. I can close that PR if you take this onn or I can rebase this one later.

Gnimuc commented 1 year ago

As this PR introduces breaking changes, we should add a guidance somewhere to let users know how to upgrade.

Another way is to rename get_file_line_column to get_filecursor_line_column and deprecate get_file_line_column in v0.18.

habemus-papadum commented 1 year ago

Thinking it through, I think it is cleaner to wrap CXFile in a CLFile, and to not make breaking changes. I will update the PR

Gnimuc commented 5 months ago

This should be added in v0.18.