search

JuliaInterop / Cxx.jl

The Julia C++ Interface
Other
757 stars 108 forks source link

WIP: Generalize standard vector code to those with arbitrary allocators. #421

Closed twadleigh closed 3 years ago

twadleigh commented 5 years ago

This is just a small part of more similar work that could be done in std.jl, but this little bit has been useful to me already.

Gnimuc commented 5 years ago

Would you like to merge this to master quickly and do other fixes in another PR, or patch all of the StdVector{T}s in this PR? I think more tests should be added in either case to improve the robustness of the code.

twadleigh commented 5 years ago

This work should already be generalized to all of the StdVector methods. The only change was widening the definition of StdVector to allow for non-standard allocators so that all the existing methods work on a wider set of types.

In that sense it could be merged now. But this would be a more complete unit of work if the same were done for the other STL types, and tests were added.

twadleigh commented 3 years ago

Stale.