search

JuliaInterop / NBInclude.jl

import code from IJulia Jupyter notebooks into Julia programs
Other
118 stars 17 forks source link

Add SoftGlobalScope flag #12

Closed arnavs closed 6 years ago

arnavs commented 6 years ago

What it says on the tin. I'm not 100% clear on the Travis/testing setup, so that may require some editing. Fixes #11.

cc: @jlperla

jlperla commented 6 years ago

Does Pkg.test work on your machine with this PR?

arnavs commented 6 years ago

Caught the error. My test without global scoping was looking for an ErrorException, of which LoadError is not a subset.

arnavs commented 6 years ago

(The Travis failures above are coming from the expected failures on 0.6 and 0.7, where this scoping rule is not broken).

jlperla commented 6 years ago

Should this feature and the tests be only run on >= v1.0 then? No need to break the builds for v0.6 and v0.7 unnecessarily. I think you can just check v"1.0" <= VERSION in the test (and the code, if necessary).

arnavs commented 6 years ago

I'll give that a shot.

stevengj commented 6 years ago

The docstrings in the code also needs an update.

arnavs commented 6 years ago

@stevengj I'm having trouble pulling your online changes into my fork. So I'll just duplicate them locally.

arnavs commented 6 years ago

OK @stevengj I think this is ready for your consumption. I've (a) updated the documentation and docstrings, (b) performed those changes on the tests, and (c) done the housekeeping on redundant files. The Travis build passes.