search

JuliaInterop / ObjectiveC.jl

Objective-C embedded in Julia
Other
39 stars 10 forks source link

Minor NSArray improvements #26

Closed maleadt closed 7 months ago

maleadt commented 7 months ago

Fixes https://github.com/JuliaInterop/ObjectiveC.jl/issues/25

This prevents constructing invalid NSArray objects (and likely segfaulting) by both constraining the type signature, and by not using the questionable Ptr{id{Object}} type signature (id is already a pointer, and relying on Julia's Ptr leads to surprising automatic conversion from otherwise incompatible array values).

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (78659ba) 69.48% compared to head (8ffbf57) 69.68%.

Files Patch % Lines
src/syntax.jl 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #26 +/- ## ========================================== + Coverage 69.48% 69.68% +0.19% ========================================== Files 9 9 Lines 626 630 +4 ========================================== + Hits 435 439 +4 Misses 191 191 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maleadt commented 7 months ago

Test failures unrelated; looks like the dispatch tests are a little fragile.