JuliaInterop / RCall.jl

Call R from Julia
Other
319 stars 59 forks source link

fix datetime to character conversion #495

Closed palday closed 1 year ago

palday commented 1 year ago

The as.character behavior seems to have been completely removed in R 4.3.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -1.70% :warning:

Comparison is base (2df5ef8) 76.86% compared to head (0793c52) 75.16%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #495 +/- ## ========================================== - Coverage 76.86% 75.16% -1.70% ========================================== Files 25 25 Lines 1664 1623 -41 ========================================== - Hits 1279 1220 -59 - Misses 385 403 +18 ``` | [Files Changed](https://app.codecov.io/gh/JuliaInterop/RCall.jl/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaInterop) | Coverage Δ | | |---|---|---| | [src/convert/default.jl](https://app.codecov.io/gh/JuliaInterop/RCall.jl/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaInterop#diff-c3JjL2NvbnZlcnQvZGVmYXVsdC5qbA==) | `91.33% <ø> (ø)` | | | [src/ijulia.jl](https://app.codecov.io/gh/JuliaInterop/RCall.jl/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaInterop#diff-c3JjL2lqdWxpYS5qbA==) | `0.00% <ø> (ø)` | | | [src/language.jl](https://app.codecov.io/gh/JuliaInterop/RCall.jl/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaInterop#diff-c3JjL2xhbmd1YWdlLmps) | `95.00% <ø> (ø)` | | | [src/methods.jl](https://app.codecov.io/gh/JuliaInterop/RCall.jl/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaInterop#diff-c3JjL21ldGhvZHMuamw=) | `68.16% <ø> (-0.35%)` | :arrow_down: | | [src/render.jl](https://app.codecov.io/gh/JuliaInterop/RCall.jl/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaInterop#diff-c3JjL3JlbmRlci5qbA==) | `87.14% <ø> (-1.43%)` | :arrow_down: | | [src/types.jl](https://app.codecov.io/gh/JuliaInterop/RCall.jl/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaInterop#diff-c3JjL3R5cGVzLmps) | `80.48% <ø> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/JuliaInterop/RCall.jl/pull/495/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaInterop)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

palday commented 1 year ago

🤔 The failed test might be a bug in Julia 1.9.2. I don't have a Windows machine handy to bisect.

ararslan commented 1 year ago

I'd recommend opening an issue on the Julia repo with the contents of the CI log (as requested by the error message 😄), I'm sure someone will be able to identify what's going on.

ararslan commented 1 year ago

The as.character behavior seems to have been completely removed in R 4.3.

Admittedly I don't really know how this package works so apologies for the naive question but do your changes work across R versions including 4.3 or do they require 4.3 at a minimum (or otherwise some minimum version different than whatever it currently is)?

palday commented 1 year ago

The as.character behavior seems to have been completely removed in R 4.3.

Admittedly I don't really know how this package works so apologies for the naive question but do your changes work across R versions including 4.3 or do they require 4.3 at a minimum (or otherwise some minimum version different than whatever it currently is)?

@ararslan They should work across R 4.x versions and maybe earlier, but I would have to go back to find which version introduced format. Also, this is "only" in tests, not in the actual package code.

ararslan commented 1 year ago

I assume then tests are guaranteed to be running R 4.x?

palday commented 1 year ago

they run on R latest so yes

palday commented 1 year ago

@ararslan I've updated the CI to run against R 3.4 (minimum supported version from deps/setup.jl, 4.0 and the current release). So that should answer the question about whether this impacts the R compat bounds. :sunglasses: