Closed palday closed 1 year ago
Patch coverage has no change and project coverage change: -1.70%
:warning:
Comparison is base (
2df5ef8
) 76.86% compared to head (0793c52
) 75.16%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🤔 The failed test might be a bug in Julia 1.9.2. I don't have a Windows machine handy to bisect.
I'd recommend opening an issue on the Julia repo with the contents of the CI log (as requested by the error message 😄), I'm sure someone will be able to identify what's going on.
The
as.character
behavior seems to have been completely removed in R 4.3.
Admittedly I don't really know how this package works so apologies for the naive question but do your changes work across R versions including 4.3 or do they require 4.3 at a minimum (or otherwise some minimum version different than whatever it currently is)?
The
as.character
behavior seems to have been completely removed in R 4.3.Admittedly I don't really know how this package works so apologies for the naive question but do your changes work across R versions including 4.3 or do they require 4.3 at a minimum (or otherwise some minimum version different than whatever it currently is)?
@ararslan They should work across R 4.x versions and maybe earlier, but I would have to go back to find which version introduced format
. Also, this is "only" in tests, not in the actual package code.
I assume then tests are guaranteed to be running R 4.x?
they run on R latest so yes
@ararslan I've updated the CI to run against R 3.4 (minimum supported version from deps/setup.jl
, 4.0 and the current release). So that should answer the question about whether this impacts the R compat bounds. :sunglasses:
The
as.character
behavior seems to have been completely removed in R 4.3.