search

JuliaInterop / RCall.jl

Call R from Julia
Other
318 stars 59 forks source link

raise julia errors #525

Open schlichtanders opened 2 months ago

schlichtanders commented 2 months ago

fixes https://github.com/JuliaInterop/RCall.jl/issues/508

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.92%. Comparing base (1517803) to head (05a680e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #525 +/- ## ========================================== - Coverage 80.40% 77.92% -2.49% ========================================== Files 26 26 Lines 1684 1685 +1 ========================================== - Hits 1354 1313 -41 - Misses 330 372 +42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlichtanders commented 1 month ago

@palday I took away the RCall. qualifier. Can you point me to the place where you would like to have the test?

ViralBShah commented 1 month ago

I believe the test to have is something that checks for the new julia error being raised as expected in this PR, so we don't regress.

palday commented 1 month ago

@schlichtanders there is an entry with the comment "callbacks" in the tests folder:

https://github.com/JuliaInterop/RCall.jl/blob/master/test/basic.jl#L67

That seems like a good place to put it. :smile: