search

JuliaInterop / libcxxwrap-julia

C++ library for backing CxxWrap.jl
Other
84 stars 43 forks source link

Add StdFill #147

Closed PraneethJain closed 7 months ago

PraneethJain commented 8 months ago

https://github.com/PraneethJain/CxxWrap.jl#main

barche commented 7 months ago

Thanks for this, the only thing I would like changed is to put the linux and mac test back on Julia 1.6 instead of 1.7, and use the 1.7 only on Windows. That way we test on the 1.6 LTS release at least on some platforms. (both this PR and the CxxWrap PR, and assuming that I saw correctly that these should pass?).

No remarks on the technical side, although it might be nice to have a common wrapper that adds methods such as resize that are common to most containers. This was the idea of the wrap_common struct. That can be done in future PRs however.