search

JuliaInterop / libcxxwrap-julia

C++ library for backing CxxWrap.jl
Other
85 stars 43 forks source link

Use other variable name than Julia_ROOT #16

Closed SylvainCorlay closed 6 years ago

SylvainCorlay commented 6 years ago

Julia_ROOT is now a reserved variable used by find_package(more generally packagename_ROOT), and it is always set by cmake from 3.12.

This caused the Julia_EXECUTABLE to not be properly set by FindJulia.cmake.

Fixing this makes the manual setting of Julia_EXECUTABLE in the config cmake file unnecessary.

SylvainCorlay commented 6 years ago

Note: this is a blocker for us to upgrade to Julia 1.0 in xtensor-julia.

SylvainCorlay commented 6 years ago

cc @barche I think that this is ready to go!

barche commented 6 years ago

Great, thanks! I think this also fixes https://github.com/JuliaInterop/CxxWrap.jl/issues/121 ?

SylvainCorlay commented 6 years ago

I think so.