search

JuliaIntervals / IntervalConstraintProgramming.jl

Calculate rigorously the feasible region for a set of real-valued inequalities with Julia
Other
63 stars 16 forks source link

remove dynamic polynomials. fixes #176 #177

Closed lucaferranti closed 3 years ago

lucaferranti commented 3 years ago

Removed tests with DynamicPolynomials, and updated Project.toml. Should fix #176

lucaferranti commented 3 years ago

The test causing problems is

    a = 3
    S4 = @constraint x^2 + y^2 - $a <= 0
    paving = pave(S4, X)

with error UndefVarError: a not defined . The failure is only on nightly, it works on 1.4 (and on 1.5, tested on my machine). What should we do with this?

lucaferranti commented 3 years ago

@dpsanders allowing failure on nightly (the other packages in juliaintervals allow it too) it seems to work. I think this is starting to look ready, what do you think?

dpsanders commented 3 years ago

Rather than just removing those tests can they be replaced with tests using ModelingToolkit variables? Or are. There similar tests already?

lucaferranti commented 3 years ago

yes, there seem to be a couple of tests using MTK with Separator here and with Contractor here

dpsanders commented 3 years ago

Thanks!