JuliaIntervals / IntervalLinearAlgebra.jl

Linear algebra done rigorously
MIT License
36 stars 9 forks source link

FEM example in documentation #112

Closed jorgepz closed 2 years ago

jorgepz commented 2 years ago

Adding draft FEM example entry to documentation.

codecov-commenter commented 2 years ago

Codecov Report

Merging #112 (247c3b1) into main (86b4edc) will increase coverage by 0.25%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   96.93%   97.18%   +0.25%     
==========================================
  Files          14       15       +1     
  Lines         489      568      +79     
==========================================
+ Hits          474      552      +78     
- Misses         15       16       +1     
Impacted Files Coverage Δ
src/IntervalLinearAlgebra.jl 100.00% <0.00%> (ø)
src/pils/linexpr.jl 98.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86b4edc...247c3b1. Read the comment docs.

jorgepz commented 2 years ago

LGTM! I left a couple of small comments. A couple of questions

1. The truss.svg can be deleted as it's not used?

2. Maybe at the end of the paragraph it might be good to comment with a sentence that the displacements are very small, but to be better visualized they are scaled by a factor of 2000, i.e. the picture is not in scale?

thanks for the comments!

  1. I would leave the svg by the moment since it is used to generate the png included. at some near future I would include the svg instead of the png... that would also improve the width and the responsiveness ...
  2. commented in 4a215ca
jorgepz commented 2 years ago

I think that the problem with the small png is due to a small resolution, I enlarged it. Also, I am adding other html options, to see how they are shown, however there is an issue with the location of the images...

lucaferranti commented 2 years ago

the issue with the svg was that the image width wasn't fit to the content. I fixed that with inkscape. I then used html to fit the width of the image to the page width, it worked locally, but apparently when deployed the path is different, I'll try to fix that next

lucaferranti commented 2 years ago

yes now it worked: https://juliaintervals.github.io/IntervalLinearAlgebra.jl/previews/PR112/applications/FEM_example/#Example-problem 🎉

jorgepz commented 2 years ago

bravissimo!