search

JuliaIntervals / IntervalLinearAlgebra.jl

Linear algebra done rigorously
MIT License
36 stars 9 forks source link

don't redefine mid for reals here #125

Closed lucaferranti closed 2 years ago

lucaferranti commented 2 years ago

PR description

before, ILA was redefining mid(x::Real) here, as this has been introduced in IntervalArithmetic 0.20.5, no need to do it anymore.

codecov-commenter commented 2 years ago

Codecov Report

Merging #125 (8e6ec49) into main (fe0161c) will increase coverage by 0.14%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   97.04%   97.19%   +0.14%     
==========================================
  Files          17       17              
  Lines         643      641       -2     
==========================================
- Hits          624      623       -1     
+ Misses         19       18       -1
Impacted Files Coverage Δ
src/IntervalLinearAlgebra.jl 100.00% <ø> (ø)
src/utils.jl 93.18% <ø> (+1.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe0161c...8e6ec49. Read the comment docs.

lucaferranti commented 2 years ago

@schillic the failure here is only on nightly (and for windows only), should we just merge this and leave the investigation to further PR instead of commenting out the tests with ICP?

schillic commented 2 years ago

Then I would suggest to allow nightly failures in the build.

schillic commented 2 months ago

@lucaferranti, I still get warnings about this conflict. Maybe tag a new release?