Closed blegat closed 2 months ago
The failure looks like https://github.com/JuliaReach/LazySets.jl/issues/3238, we need to update to LazySets v2 it seems
LazySets does not support v0.22 of IntervalArithmetic.
LazySets does not support v0.22 of IntervalArithmetic.
neither does ILA, so there should be no problem I think?
IntervalConstraintProgramming.jl only supports v0.20 it seems anyway
The documentation errors because some non-exported abstract type are not included in the docs. autodocs
does not include them because Private = false
is used an option. We can either use Private = true
or export these abstract types, what do you prefer ?
The documentation errors because some non-exported abstract type are not included in the docs.
autodocs
does not include them becausePrivate = false
is used an option. We can either usePrivate = true
or export these abstract types, what do you prefer ?
I think we can just set Private = true
for now. I need to do some repo clean up at some point, sorry you hit all these corners
There are still other documentation failures, maybe we can merge this PR since it's unrelated and fix this in another one ?
@lucaferranti @schillic bump :)
Sorry! I ll sort this out tomorrow while travelling to JuliaCon (see you there if you are coming)
Thanks! Unfortunately I won't be able to attend this year
@blegat this is merged now, but for some reason the documentation deployment fails on main, I'll try to debug it. (Help welcome if you spot the reason)
The error message is:
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
I cannot see any green checkmarks next to the commits on master
, so maybe this never worked? It is interesting that it worked on this fork, though. In any case, I do not see how this PR would be the cause.
In any case, I do not see how this PR would be the cause.
It's definitely not, but I think we still need to fix that otherwise when making a release it will not build the docs
One should double check the setup with secret keys etc... as detailed in https://documenter.juliadocs.org/stable/man/hosting/ I would guess this is the cause but I don't have the permission to check
yeah it might be I messed that up at some point and went unnoticed till now
@lucaferranti Just had the same issue when updating a package. It seems that the setup changed at some point. Try
] dev IntervalLinearAlgebra
julia> using DocumenterTools
julia> DocumenterTools.genkeys(IntervalLinearAlgebra)
┌ Info: Add the key below as a new 'Deploy key' on GitHub (https://github.com/JuliaIntervals/IntervalLinearAlgebra.jl/settings/keys) with read and write access.
└ The 'Title' field can be left empty as GitHub can infer it from the key comment.
ssh-rsa ... Documenter
[ Info: Add a secure 'Repository secret' named 'DOCUMENTER_KEY' (to https://github.com/JuliaIntervals/IntervalLinearAlgebra.jl/settings/secrets if you deploy using GitHub Actions) with value:
...
I'm guessing that you will see that you did not have a deploy key even if you had a repo secret (that was my case). By adding a deploy key and updating the secret, I got things to work again.
Thanks @blegat ! That indeed fixed the problem! Pretty trivial in retrospection.
Now documentation is green on main, I'll tag a new patch release as soon as workflow ends
eigenbox
is currently failing withLooking at other places where
radius
is used in the package, it seems that it's simply not exported byIntervalArithmetic
so we need an explicit prefix