search

JuliaIntervals / IntervalRootFinding.jl

Library for finding the roots of a function using interval arithmetic
https://juliaintervals.github.io/IntervalRootFinding.jl/
Other
129 stars 25 forks source link

Add promotion_rule to handle promotion involving Dual #15

Closed lbenet closed 7 years ago

lbenet commented 7 years ago

Related to https://github.com/JuliaIntervals/IntervalArithmetic.jl/pull/13

lbenet commented 7 years ago

This is an alternative to #12...

dpsanders commented 7 years ago

Are these actually necessary, though? The package seems to work fine without any of these promotion rules.

lbenet commented 7 years ago

I don't recall why we needed them at all. So I'll close this and we check #12.

dpsanders commented 7 years ago

I think we needed them because of some ambiguities on Julia 0.4. But it seems they were only "potential" ambiguities that were never actually encountered!

codecov-io commented 7 years ago

Codecov Report

Merging #15 into master will decrease coverage by 0.36%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   82.18%   81.81%   -0.37%     
==========================================
  Files           5        5              
  Lines         174      176       +2     
==========================================
+ Hits          143      144       +1     
- Misses         31       32       +1
Impacted Files Coverage Δ
src/IntervalRootFinding.jl 85.45% <50%> (-1.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 620eed3...2c79a28. Read the comment docs.