search

JuliaIntervals / IntervalRootFinding.jl

Library for finding the roots of a function using interval arithmetic
https://juliaintervals.github.io/IntervalRootFinding.jl/
Other
125 stars 26 forks source link

export interval definition for convenience #176

Closed Datseris closed 2 years ago

lucaferranti commented 2 years ago

did you know about ValidatedNumerics.jl which exports all (well almost) julia intervals packages at once?

Nevertheless, I see no harm in this PR, as someone may just want to use IntervalRootFinding without e.g. ICP and TaylorModels.

Just one commment, why not using @reexport IntervalArithmetic instead of just re-exporting the ..?

Datseris commented 2 years ago

I didn't know of validatedNumerics.jl, but I do not think that would be a viable option for my case (which adds a package as a dependency to some other package), as one needs to minimize dependencies.

Sure @reexport IntervalArithmetic is better, I'll do that one.

Datseris commented 2 years ago

That is a good idea, yes. We just have to make sure that there is no problem if you also explicitly import IntervalArithmetic.jl.

Yes this is totally fine, I've already tested it in DynamicalSystems.jl. Julia understands that the .. that this package exports does come from IntervalArithemtic.jl and there will be no conflicts even if you import it.

Datseris commented 2 years ago

This is good to go I think.

lucaferranti commented 2 years ago

LGTM, thanks!

lucaferranti commented 2 years ago

@Datseris the new release should now be available in the Julia registry.