Remove old code - Githubissues

JuliaIntervals / IntervalRootFinding.jl

Library for finding the roots of a function using interval arithmetic

https://juliaintervals.github.io/IntervalRootFinding.jl/

Other

127 stars 26 forks source link

Remove old code #41

Open dpsanders opened 6 years ago

dpsanders commented 6 years ago

Remove old code:

[x] bisection.jl
[x] move out definitions of N used in branch_and_prune
[ ] krawczyk.jl
[ ] newton.jl
[ ] find_roots stuff

Kolaru commented 5 years ago

Is the code in newton1d.jl still considered maintained and part of the current API ?

dpsanders commented 5 years ago

That was added in last year's GSoC project.

In a way it's useful to have a separate code, but the actual code itself is long and convoluted. We should see if anything is salvagable and probably get rid of the rest.

cc @eeshan9815

eeshan9815 commented 5 years ago

If I recall correctly, it worked well for complicated functions, and functions which had a lot of multiple roots, where the existing solver sometimes struggled. So, should it be implemented as a part of the roots interface and kept as a different keyword solver?