JuliaIntervals / IntervalRootFinding.jl

Library for finding the roots of a function using interval arithmetic
https://juliaintervals.github.io/IntervalRootFinding.jl/
Other
127 stars 26 forks source link

Implement Krawczyk method #57

Closed Kolaru closed 6 years ago

Kolaru commented 6 years ago
codecov-io commented 6 years ago

Codecov Report

Merging #57 into master will increase coverage by 1.82%. The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   46.31%   48.13%   +1.82%     
==========================================
  Files           9        9              
  Lines         339      349      +10     
==========================================
+ Hits          157      168      +11     
+ Misses        182      181       -1
Impacted Files Coverage Δ
src/contractors.jl 95% <100%> (+1.66%) :arrow_up:
src/roots.jl 85.24% <66.66%> (ø) :arrow_up:
src/root_object.jl 25% <0%> (+12.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca91b8b...f84b312. Read the comment docs.

dpsanders commented 6 years ago

Looks good, thanks a lot!

dpsanders commented 6 years ago

Please don't include merge commits. I think you should be rebasing instead:

git checkout master
git pull upstream master

git checkout <your-branch>
git rebase master

Here, upstream is the remote that points to this repo.

dpsanders commented 6 years ago

Ah and then git push -f to force push the changes to the current branch.

dpsanders commented 6 years ago

Looks good to me, thanks a lot!