search

JuliaIntervals / IntervalRootFinding.jl

Library for finding the roots of a function using interval arithmetic
https://juliaintervals.github.io/IntervalRootFinding.jl/
Other
127 stars 26 forks source link

Add missing deriv #62

Closed dpsanders closed 6 years ago

lbenet commented 6 years ago

Thanks! The sole comment i have is related to the default tol. In the fall-back method, tol's default is 1.0e-15; other methods use 1.e-3. I think this is a good opportunity to fix a common default.

Shall I go ahead and merge (and leave the common tol default for another PR) or do you plan to make further changes?

dpsanders commented 6 years ago

No more changes planned. Yes, not sure what to do about the default tol.

lbenet commented 6 years ago

Mwrging. We can set a common default for tol in another PR.

Thanks a lot!