Closed lbenet closed 6 years ago
Merging #65 into master will increase coverage by
0.44%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #65 +/- ##
=========================================
+ Coverage 47.86% 48.3% +0.44%
=========================================
Files 9 9
Lines 351 354 +3
=========================================
+ Hits 168 171 +3
Misses 183 183
Impacted Files | Coverage Δ | |
---|---|---|
src/roots.jl | 85.93% <100%> (+0.69%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 13bc215...71ca13e. Read the comment docs.
This seems like a cleaner API to me. Do you have any comments, @Kolaru ?
Thanks!
In the new commit, I also deleted the dependency on deriv
for roots
using the Bisection
contractor.
I have no special comment, everything looks good to me.
@dpsanders Shall I merge this? I would also propose to tag a new patch version
Yes please, go ahead and merge. We should tag a minor version once all the current PRs are merged, since the API has changed (?)
My proposal is to tag a patch version only; I have some tests which require some merged PRs after v0.2.0.
@dpsanders I tried to tag a new patch version (v0.2.1), so I can keep on working on TaylorModels; yet, some dependencies had broken tests (see https://github.com/JuliaLang/METADATA.jl/pull/14657). Do you know how to try this again? I am not sure if I should delete the version and then tag a new one.
See also https://github.com/JuliaIntervals/ValidatedNumerics.jl/pull/284, which solves the issues for ValidatedNumerics.
Yes, the easiest way is to delete the release and the tag and make the release again.
On Tue, 15 May 2018, 1:12 pm Luis Benet, notifications@github.com wrote:
@dpsanders https://github.com/dpsanders I tried to tag a new patch version (v0.2.1), so I can keep on working on TaylorModels; yet, some dependencies had broken tests (see JuliaLang/METADATA.jl#14657 https://github.com/JuliaLang/METADATA.jl/pull/14657). Do you know how to try this again? I am not sure if I should delete the version and then tag a new one.
See also JuliaIntervals/ValidatedNumerics.jl#284 https://github.com/JuliaIntervals/ValidatedNumerics.jl/pull/284, which solves the issues for ValidatedNumerics.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaIntervals/IntervalRootFinding.jl/pull/65#issuecomment-389262332, or mute the thread https://github.com/notifications/unsubscribe-auth/AALtTuaqv7dAbBvINBuz6OFVpK_QOJYGks5tyxqIgaJpZM4T1fvS .
Fixes #64