JuliaIntervals / IntervalRootFinding.jl

Library for finding the roots of a function using interval arithmetic
https://juliaintervals.github.io/IntervalRootFinding.jl/
Other
127 stars 26 forks source link

Add some hard test cases from Smiley and Chun (2001) #70

Closed gwater closed 6 years ago

gwater commented 6 years ago

Addresses plans in #44 to implement some more difficult test cases by implementing 4 examples from M. W. Smiley and C. Chun, J. Comput. Appl. Math. 137, 293 (2001).

Currently all examples pass (using the Newton method). However, Example 5.5 takes ca 40 minutes on my machine. Therefore it might not be practicable to include the test cases in the default set of tests.

Example 5.5 might be useful for benchmarks and checking for performance regressions.

codecov-io commented 6 years ago

Codecov Report

Merging #70 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   56.14%   56.14%           
=======================================
  Files          10       10           
  Lines         431      431           
=======================================
  Hits          242      242           
  Misses        189      189

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6491d43...2c7566b. Read the comment docs.

dpsanders commented 6 years ago

Looks good at a first glance, thanks!

lbenet commented 6 years ago

While all tests are passing, there seems to be a conflict with current master in test/runtests.jl; can you rebase to current master?

gwater commented 6 years ago

@lbenet ok, rebased to current master.

lbenet commented 6 years ago

Thanks a lot; tests are passing. I am in favor of merging this.

@dpsanders Do you agree?

lbenet commented 6 years ago

Apparently Example 5.5 fails on Travis CI, too. To be honest though, hunting this bug seems outside the scope of this pull request to me. (Clearly, the tests are uncovering an issue here but that does not mean they are broken or wrong.)

I agree with you; would you mind open an issue on that?

Regarding this PR, and precisely to go on having these more stringent tests, I propose to comment that test and merge this PR. Then, we can try to track down the problem.

Maybe @dpsanders has another idea?

dpsanders commented 6 years ago

That sounds good to me; comment out the failing test and add an issue about it; enable the tests and merge!

lbenet commented 6 years ago

Thanks a lot con this contribution! Merging.