search

JuliaIntervals / IntervalRootFinding.jl

Library for finding the roots of a function using interval arithmetic
https://juliaintervals.github.io/IntervalRootFinding.jl/
Other
127 stars 26 forks source link

Add slope interval newton method #73

Open eeshan9815 opened 6 years ago

eeshan9815 commented 6 years ago

@dpsanders Rebased "slope" and "debug-newton1d" branches onto this branch before adding more commits.

eeshan9815 commented 6 years ago

AppVeyor build is failing on Windows 32-bit, one of the 3D roots tests is failing.

dpsanders commented 6 years ago

Could you rebase please?

codecov-io commented 6 years ago

Codecov Report

Merging #73 into master will increase coverage by 0.78%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   64.97%   65.76%   +0.78%     
==========================================
  Files          11       11              
  Lines         551      552       +1     
==========================================
+ Hits          358      363       +5     
+ Misses        193      189       -4
Impacted Files Coverage Δ
src/slopes.jl 83.33% <ø> (+4.76%) :arrow_up:
src/IntervalRootFinding.jl 4.65% <ø> (ø) :arrow_up:
src/newton1d.jl 87.38% <100%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a0027a...8c45266. Read the comment docs.

dpsanders commented 6 years ago

Another rebase required here...

eeshan9815 commented 6 years ago

Done!

dpsanders commented 6 years ago

There's a real test error.

eeshan9815 commented 6 years ago

Sorry that happened due to an error while resolving the merge conflicts. It should work fine now.

dpsanders commented 6 years ago

The function slope_newton1d should be refactored into the newton1d function, e.g. with a keyword arg.