Closed mforets closed 3 years ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/validatedODEs.jl | 33 | 56 | 58.93% | ||
<!-- | Total: | 36 | 59 | 61.02% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/arithmetic.jl | 1 | 76.58% | ||
src/auxiliary.jl | 1 | 55.36% | ||
src/validatedODEs.jl | 3 | 69.29% | ||
<!-- | Total: | 5 | --> |
Totals | |
---|---|
Change from base Build 640233573: | 4.2% |
Covered Lines: | 708 |
Relevant Lines: | 1176 |
I've updated the title of the PR because the branch is still WIP: some additional arguments need to be passed to the initialization functions (eg. orderT
) while for others such as the symmetric intreval box I think it's better to define it as a function, say symIbox(N) = ...
.
This is now ready for review. Tests pass locally (julia v1.5.2).
Thanks a lot for addressing #92!
LGTM. Could you perhaps add some tests for the new method? (Maybe simply adapt the existing ones?)
for others such as the symmetric intreval box I think it's better to define it as a function, say symIbox(N) = ....
this could be defined in IntervalArithmetic.jl (see https://github.com/JuliaIntervals/IntervalArithmetic.jl/pull/446)
Should we merge this? Or you'd like to add some further tests?
I would prefer to have some tests... it always helps!
The last commit adds 2 new tests for the functionality of starting validated_integ
with a vector of TMs.
Do you have some other dynamical system in mind to make a new test?
I'll merge it and release a new patch version. Thanks again!
Closes #92.