JuliaIntervals / TaylorModels.jl

Rigorous function approximation using Taylor models in Julia
Other
63 stars 14 forks source link

#92 - Generalize input of validated integ #103

Closed mforets closed 3 years ago

mforets commented 3 years ago

Closes #92.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 664234099

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/validatedODEs.jl 33 56 58.93%
<!-- Total: 36 59 61.02% -->
Files with Coverage Reduction New Missed Lines %
src/arithmetic.jl 1 76.58%
src/auxiliary.jl 1 55.36%
src/validatedODEs.jl 3 69.29%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 640233573: 4.2%
Covered Lines: 708
Relevant Lines: 1176

💛 - Coveralls
mforets commented 3 years ago

I've updated the title of the PR because the branch is still WIP: some additional arguments need to be passed to the initialization functions (eg. orderT) while for others such as the symmetric intreval box I think it's better to define it as a function, say symIbox(N) = ....

mforets commented 3 years ago

This is now ready for review. Tests pass locally (julia v1.5.2).

lbenet commented 3 years ago

Thanks a lot for addressing #92!

LGTM. Could you perhaps add some tests for the new method? (Maybe simply adapt the existing ones?)

mforets commented 3 years ago

for others such as the symmetric intreval box I think it's better to define it as a function, say symIbox(N) = ....

this could be defined in IntervalArithmetic.jl (see https://github.com/JuliaIntervals/IntervalArithmetic.jl/pull/446)

mforets commented 3 years ago

Should we merge this? Or you'd like to add some further tests?

lbenet commented 3 years ago

I would prefer to have some tests... it always helps!

mforets commented 3 years ago

The last commit adds 2 new tests for the functionality of starting validated_integ with a vector of TMs.

Do you have some other dynamical system in mind to make a new test?

lbenet commented 3 years ago

I'll merge it and release a new patch version. Thanks again!