JuliaIntervals / TaylorModels.jl

Rigorous function approximation using Taylor models in Julia
Other
63 stars 14 forks source link

undo times vector change #119

Closed mforets closed 3 years ago

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 884375509


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/validatedODEs.jl 3 5 60.0%
<!-- Total: 3 5 60.0% -->
Totals Coverage Status
Change from base Build 883408675: 0.0%
Covered Lines: 773
Relevant Lines: 1220

💛 - Coveralls
lbenet commented 3 years ago

I don't think this change is necessary, as I explained in this comment. The current (master) behavior is more consistent with respect to indexing, in such a way that the returned time at step n corresponds to the origin of the domain of the n-th entry of the solution, while before, it was the n-1 time entry.

mforets commented 3 years ago

but then, the length should be n+1? (or don't return the first reachable set at the time point t0). otherwise, we don't know by looking only at tTM when does the flowpipe end as i showed in this example

lbenet commented 3 years ago

The length is actually maxsteps+1 (see here). The extra 1 comes from the initial condition, which i kept because it's sometimes handy to use directly the TaylorModel1 of that initial condition, as we do it in the tests (see here).

See #117 to see how everything becomes more consistent.

mforets commented 3 years ago

i still think that it is unexpected to just see two zeros in the example above instead of [0, 0, 0.1] (because validated_integ returns a view of only the maxsteps terms of tTM, not the full maxsteps+1) but ok :thumbsup: