Closed lbenet closed 2 years ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/validatedODEs.jl | 2 | 4 | 50.0% | ||
<!-- | Total: | 2 | 4 | 50.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/bounds.jl | 1 | 94.41% | ||
src/evaluate.jl | 1 | 86.67% | ||
src/show.jl | 1 | 81.25% | ||
src/Taylor1/draw.jl | 1 | 0.0% | ||
src/auxiliary.jl | 2 | 55.22% | ||
src/rpa_functions.jl | 2 | 84.17% | ||
src/Taylor1/bound.jl | 2 | 0.0% | ||
src/TaylorN/integrate.jl | 2 | 0.0% | ||
src/TaylorN/TaylorN.jl | 2 | 0.0% | ||
src/Taylor1/arithmetic.jl | 3 | 0.0% | ||
<!-- | Total: | 72 | --> |
Totals | |
---|---|
Change from base Build 1174353579: | 1.2% |
Covered Lines: | 985 |
Relevant Lines: | 1523 |
Since IntervalArithmetics.jl
currently requires Julia 1.5, I guess it makes sense to require the same here at least; this would solve the broken tests (due to the introduction of numtype
).
cc @lucaferranti
Should we require IntervalArithmetic v0.20 and later? And then bump a new minor version.
Should we require IntervalArithmetic v0.20 and later?
Either that or you need to make the change eltype
→ numtype
version dependent. (I guess it would fail with older versions of IA, which you do not see in the build here because it only uses the latest version.)
huups, apologies for not noticing you tagged me. Anyway, I agree with Christian that it may make sense to update the compatibilities with IA and Julia. The documentation check seems to fail, but it seems to be unrelated to this PR
@lucaferranti Thanks for the comment; do you understand the problem with the docs? Locally, I can't reproduce it.
Have you tried retriggering? It could just be a random failure.
it was a plotting related issue, when Plots.jl is used with the GR backend, then it requires the small trick of my latest commit, more details here.
I am not sure why this didn't come up before, probably because this PR added Plots.jl
as deps in the docs Project.toml
Thanks @lucaferranti for fixing this! So I'll merge and then tag the new version!
See this comment for the problem.