JuliaIntervals / TaylorModels.jl

Rigorous function approximation using Taylor models in Julia
Other
63 stars 14 forks source link

Solve failing tests (validated_integ.jl) #126

Closed lbenet closed 2 years ago

lbenet commented 2 years ago

See this comment for the problem.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1400889420

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/validatedODEs.jl 2 4 50.0%
<!-- Total: 2 4 50.0% -->
Files with Coverage Reduction New Missed Lines %
src/bounds.jl 1 94.41%
src/evaluate.jl 1 86.67%
src/show.jl 1 81.25%
src/Taylor1/draw.jl 1 0.0%
src/auxiliary.jl 2 55.22%
src/rpa_functions.jl 2 84.17%
src/Taylor1/bound.jl 2 0.0%
src/TaylorN/integrate.jl 2 0.0%
src/TaylorN/TaylorN.jl 2 0.0%
src/Taylor1/arithmetic.jl 3 0.0%
<!-- Total: 72 -->
Totals Coverage Status
Change from base Build 1174353579: 1.2%
Covered Lines: 985
Relevant Lines: 1523

💛 - Coveralls
lbenet commented 2 years ago

Since IntervalArithmetics.jl currently requires Julia 1.5, I guess it makes sense to require the same here at least; this would solve the broken tests (due to the introduction of numtype).

cc @lucaferranti

lbenet commented 2 years ago

Should we require IntervalArithmetic v0.20 and later? And then bump a new minor version.

schillic commented 2 years ago

Should we require IntervalArithmetic v0.20 and later?

Either that or you need to make the change eltype → numtype version dependent. (I guess it would fail with older versions of IA, which you do not see in the build here because it only uses the latest version.)

lucaferranti commented 2 years ago

huups, apologies for not noticing you tagged me. Anyway, I agree with Christian that it may make sense to update the compatibilities with IA and Julia. The documentation check seems to fail, but it seems to be unrelated to this PR

lbenet commented 2 years ago

@lucaferranti Thanks for the comment; do you understand the problem with the docs? Locally, I can't reproduce it.

schillic commented 2 years ago

Have you tried retriggering? It could just be a random failure.

lucaferranti commented 2 years ago

it was a plotting related issue, when Plots.jl is used with the GR backend, then it requires the small trick of my latest commit, more details here.

I am not sure why this didn't come up before, probably because this PR added Plots.jl as deps in the docs Project.toml

lbenet commented 2 years ago

Thanks @lucaferranti for fixing this! So I'll merge and then tag the new version!