Update documentation of TaylorNModel

JuliaIntervals / TaylorModels.jl

Rigorous function approximation using Taylor models in Julia

Other

63 stars 14 forks source link

Update documentation of TaylorNModel #145

Closed schillic closed 1 year ago

schillic commented 1 year ago

I was not sure how to describe order_bounds.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4235146100

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.057%

Totals
Change from base Build 4125212071:	0.0%
Covered Lines:	1
Relevant Lines:	1761

💛 - Coveralls

lucaferranti commented 1 year ago

WoW! quite a lot of damage for a docstring update! :rofl:

Just kiding it fails on main too. @lbenet do you remember off the top of your head if some feature depending on 1.9 was recently introduced? Otherwise I can try to have a look at this at some point (this is not related to this MR though)

lucaferranti commented 1 year ago

relevant stacktrace

ERROR: LoadError: UndefVarError: RetAlloc not defined
Stacktrace:
 [1] getproperty(x::Module, f::Symbol)
   @ Base ./Base.jl:31
 [2] top-level scope
   @ ~/work/TaylorModels.jl/TaylorModels.jl/src/validatedODEs.jl:420
 [3] include(mod::Module, _path::String)

lbenet commented 1 year ago

The problems were introduced by merging https://github.com/JuliaDiff/TaylorSeries.jl/pull/312. TS was processing inconsistently the series of some functions for intervals, in the sense of not caring for the natural domain of the function. I started working on that, but got distracted. Sorry...

schillic commented 1 year ago

Given that the build failures are unrelated, is there anything you expect me to do here?

lbenet commented 1 year ago

Regarding Taylor1Model and TaylorNModel, these were some structs defined during early essays, which have been left there; they do not allow the functionality that has been implemented for TaylorModel1 and TaylorModelN. So, I don't think it is worth using them... Sorry for the very late response, I just noticed this.

Regarding the failure of the tests, as I mentioned it is related to https://github.com/JuliaDiff/TaylorSeries.jl/pull/312; it seems to me that the problem is the tests we implemented for TaylorModel1{TaylorN{T}}. Again, I haven't had time to get into that, but I'll try to remedy soon.

schillic commented 1 year ago

Okay, then I close this PR.

lbenet commented 1 year ago

Thanks... and sorry for the veeery late response...

schillic commented 1 year ago

No problem. Regarding the other problem, you have a branch that seems to work (#146). Maybe you can just merge that? :)