JuliaIntervals / TaylorModels.jl

Rigorous function approximation using Taylor models in Julia
Other
63 stars 14 forks source link

Adapting TaylorSeries # 312 #146

Closed lbenet closed 1 year ago

lbenet commented 1 year ago

TaylorSeries #312 solved some inconsistencies that involve Taylor1{Interval{T}}; the changes broke some tests here, that involve TaylorModel1{TaylorN} and RTaylorModel1{TaylorN} only with the log function. This PR aims solving that.

I currently suspect that the these tests fail because, somehow we end up being outside of the domain...

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4694484458

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
src/evaluate.jl 1 85.71%
src/rpa_functions.jl 7 86.71%
src/auxiliary.jl 8 56.94%
src/promotion.jl 17 3.57%
src/arithmetic.jl 21 82.61%
<!-- Total: 54 -->
Totals Coverage Status
Change from base Build 4125212071: 67.1%
Covered Lines: 1179
Relevant Lines: 1755

💛 - Coveralls
lbenet commented 1 year ago

@schillic I'm replying to your comment here: The tests do pass here, because I am skipping the problematic tests. I will merge a new PR in parallel (with the changes implemented so far here), to keep this PR open since the issue related to https://github.com/JuliaDiff/TaylorSeries.jl/pull/312 hasn't been solved; I'll also tag a new version.

lbenet commented 1 year ago

Closed by mistake... I'll take care of this later