JuliaIntervals / TaylorModels.jl

Rigorous function approximation using Taylor models in Julia
Other
63 stars 14 forks source link

A new approach for the validated integration of ODEs #84

Closed ulinares closed 3 years ago

ulinares commented 4 years ago

The test for the dx/dt=x^2 relies on the new method forremainder_product function from eeafb27. So, for now, that test will fail.

lbenet commented 4 years ago

Thanks for addressing this!

lbenet commented 4 years ago

Some tests, which are not currently passing, should be fixed by #91; you may need to rebase once it is merged.

ulinares commented 4 years ago

Great, I'll wait for it.

lbenet commented 3 years ago

@UzielLinares Can you rebase to current master? This should run the tests using GitHub actions, and (perhaps) solve the problems spotted by travis. (GH actions is much faster than travis.)

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 668815412

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/integration.jl 0 11 0.0%
src/validatedODEs.jl 0 88 0.0%
<!-- Total: 0 99 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/show.jl 2 66.67%
src/auxiliary.jl 9 37.74%
src/constructors.jl 15 48.28%
src/integration.jl 20 17.46%
src/evaluate.jl 23 35.56%
src/rpa_functions.jl 34 55.83%
src/arithmetic.jl 62 37.97%
src/bounds.jl 68 52.41%
src/validatedODEs.jl 215 0.0%
<!-- Total: 448 -->
Totals Coverage Status
Change from base Build 640233573: 1.8%
Covered Lines: 740
Relevant Lines: 1280

💛 - Coveralls
lbenet commented 3 years ago

Thanks for rebasing to master! There was a broken test (windows, 1.3) which i couldn't understand, so I rerun the tests and now they are passing.

lbenet commented 3 years ago

There are still some broken tests on nightly (1.7.0-DEV)

lbenet commented 3 years ago

There seem to be some conflicts (in tests/validated_integ.jl); can you resolve them?

lbenet commented 3 years ago

Maybe duplicating the tests (old a new methods are tested) is the best...

lbenet commented 3 years ago

There is one test that seems to be stuck...

lbenet commented 3 years ago

The tests pass, but there is something preventing a test to complete. I'll simply go ahead and merge this to have this functionality in master. We can finish whatever is left later in a different PR.

Thanks a lot @UzielLinares!!!

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 668837497

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/integration.jl 10 11 90.91%
src/validatedODEs.jl 67 84 79.76%
<!-- Total: 77 95 81.05% -->
Files with Coverage Reduction New Missed Lines %
src/arithmetic.jl 1 76.58%
src/auxiliary.jl 1 52.83%
src/validatedODEs.jl 94 55.99%
<!-- Total: 96 -->
Totals Coverage Status
Change from base Build 640233573: 1.7%
Covered Lines: 737
Relevant Lines: 1276

💛 - Coveralls