Closed ulinares closed 3 years ago
Thanks for addressing this!
Some tests, which are not currently passing, should be fixed by #91; you may need to rebase once it is merged.
Great, I'll wait for it.
@UzielLinares Can you rebase to current master? This should run the tests using GitHub actions, and (perhaps) solve the problems spotted by travis. (GH actions is much faster than travis.)
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/integration.jl | 0 | 11 | 0.0% | ||
src/validatedODEs.jl | 0 | 88 | 0.0% | ||
<!-- | Total: | 0 | 99 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/show.jl | 2 | 66.67% | ||
src/auxiliary.jl | 9 | 37.74% | ||
src/constructors.jl | 15 | 48.28% | ||
src/integration.jl | 20 | 17.46% | ||
src/evaluate.jl | 23 | 35.56% | ||
src/rpa_functions.jl | 34 | 55.83% | ||
src/arithmetic.jl | 62 | 37.97% | ||
src/bounds.jl | 68 | 52.41% | ||
src/validatedODEs.jl | 215 | 0.0% | ||
<!-- | Total: | 448 | --> |
Totals | |
---|---|
Change from base Build 640233573: | 1.8% |
Covered Lines: | 740 |
Relevant Lines: | 1280 |
Thanks for rebasing to master! There was a broken test (windows, 1.3) which i couldn't understand, so I rerun the tests and now they are passing.
There are still some broken tests on nightly (1.7.0-DEV)
There seem to be some conflicts (in tests/validated_integ.jl
); can you resolve them?
Maybe duplicating the tests (old a new methods are tested) is the best...
There is one test that seems to be stuck...
The tests pass, but there is something preventing a test to complete. I'll simply go ahead and merge this to have this functionality in master. We can finish whatever is left later in a different PR.
Thanks a lot @UzielLinares!!!
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/integration.jl | 10 | 11 | 90.91% | ||
src/validatedODEs.jl | 67 | 84 | 79.76% | ||
<!-- | Total: | 77 | 95 | 81.05% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/arithmetic.jl | 1 | 76.58% | ||
src/auxiliary.jl | 1 | 52.83% | ||
src/validatedODEs.jl | 94 | 55.99% | ||
<!-- | Total: | 96 | --> |
Totals | |
---|---|
Change from base Build 640233573: | 1.7% |
Covered Lines: | 737 |
Relevant Lines: | 1276 |
The test for the
dx/dt=x^2
relies on the new method forremainder_product
function from eeafb27. So, for now, that test will fail.