search

JuliaIntervals / TaylorModels.jl

Rigorous function approximation using Taylor models in Julia
Other
63 stars 14 forks source link

Update examples.jl #95

Closed mforets closed 3 years ago

mforets commented 3 years ago

The file examples/examples.jl contains code from earlier versions of the package and may be confusing (https://github.com/JuliaIntervals/TaylorModels.jl/issues/94).

lbenet commented 3 years ago

Thanks @mforets for addressing #94; some tests are not passing, but only in Julia 1.1, which maybe related to some mismatch of versions. I'll try to check this in detail later.

mforets commented 3 years ago

Did you consider dropping julia v1.1 from CI? (The error originates with the versions of TaylorSeries installed by CI, see here, but that package doesn't explicitly test on Julia v1.1, see here).

lbenet commented 3 years ago

Sorry for the delay to answer...

I am not sure about the problem with Julia v1.1 with TaylorSeries (it seems related to evaluate), but I recall that IntervalArithmetic requires Julia 1.3. So, I agree to drop testing on Julia 1.1 and everything below 1.3.

mforets commented 3 years ago

I've rebased w/master so that CI is triggered again.

lbenet commented 3 years ago

Thanks a lot @mforets. Tests pass, so I'll merge. Later, I'll tag a new (patch) version.

mforets commented 3 years ago

great, thanks !