search

JuliaInv / JOcTree

Other
4 stars 6 forks source link

getNodalConstraints bugfix and addition of createOcTreeFromSrcRec #2

Closed Pbellive closed 7 years ago

Pbellive commented 7 years ago

Also update in createOcTreeFromImage and readme update

lruthotto commented 7 years ago

@Pbellive: Is this ready to be merged?

Pbellive commented 7 years ago

I would go ahead and merge Roman's changes (#4). This PR has relatively minor changes that may have already been fixed by #4. Once it gets merged here I'll get the changes into my local copy and either update this PR or close it. Does that work?

lruthotto commented 7 years ago

Alright #4 is merged. Please take a look which changes from this one to keep!

Pbellive commented 7 years ago

This PR is way out of date. The changes I contributed to it have been added elsewhere. However it also has a bunch of commits from @samywu and @lruthotto that look to be worth keeping, especially the updates to createOcTreeFromImage. Would one of you mind merging your local improvements to the latest version of JOcTree and making a new PR? By latest version I probably mean master after #8 gets merged. I'm sorry to create more work but you're probably in a better position than me to decide which of you're changes you'd still like merged.

On a related note, Roman has been writing unit tests for JOcTree. I plan to sit with him on Monday and help get them onto GitHub, at which point it will make sense to get CI up and running.

dwfmarchant commented 7 years ago

Out of date.