search

JuliaInv / JOcTree

Other
4 stars 7 forks source link

Speedup edge mass matrices #20

Closed Pbellive closed 7 years ago

Pbellive commented 7 years ago

Go back to using old method of constructing edge mass matrices for isotropic models. Provides massive speedups (20X and higher ) on mass matrix and derivative of mass matrix construction.

cschwarzbach commented 7 years ago

I wonder if we should drop redundant output argument(s) in functions with exclamation mark which modify the input argument(s). The function concerned here is DiagTimesMTimesDiag!. I find it confusing to see, e.g., CURL = DiagTimesMTimesDiag!(FSZi, T, ESZ) where CURL and T will point to the same memory location. What's the official Julia rule on this?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.9%) to 41.027% when pulling cfe311595b2531db57e7ab730000b78440537879 on speedupEdgeMassMatrices into d132a6e92612973961cb266c04a5bceecbd773a4 on master.

Pbellive commented 7 years ago

I think the Julia best practice is to avoid the redundant outputs. We should do this.