search

JuliaInv / MUMPSjInv.jl

MUMPS interface for Julia
18 stars 15 forks source link

Updated remotecall syntax for v0.5 and Compat and BaseTestNext #12

Closed Pbellive closed 7 years ago

Pbellive commented 7 years ago

Hi Lars, This PR updates MUMPS.jl for julia v0.5. It uses the Compat and BaseTestNext packages to maintain backward compatibility with v0.4. It's been tested on 0.4 and 0.5 but not on 0.3.

Patrick

lruthotto commented 7 years ago

Looks all great to me. Just one comment about loading Base.Test. Are you sure we need to use all these if statements?

Pbellive commented 7 years ago

Hi Lars, We don't need all the if statements. MUMPS.jl doesn't currently use any of the new 0.5 testing functionality that requires BaseTestNext for 0.4 compatibility. However, I think it's a good practice in general to use BaseTestNext in case one wanted to change the testing to use some new features. As far as I understand Compat doesn't take care of the functionality of the BaseTestNext if statements.

Anyway, I can remove the if statements or leave them in. Let me know what you'd prefer.

lruthotto commented 7 years ago

Well, alright. Let's leave them in then and see what happens towards 1.0.