JuliaLabs / Cassette.jl

Overdub Your Julia Code
Other
371 stars 35 forks source link

Call pass function in newest world-age. #149

Closed vchuravy closed 4 years ago

vchuravy commented 5 years ago

Sometimes it helps to take a step back to remember why we do what we do. The method overwrite for overdub is done because the pass is defined by the user in a world-age after the definition of overdub. Instead of overwritting it (and running into issues during precompilation), we can call the pass function always in the newest world-age.

fixes #113

cc: @nhdaly

NHDaly commented 5 years ago

Just following up here, did we ultimately decide the best approach would be to require users to pass their Pass in when creating their Context? :) A lateral Pass pass?

vchuravy commented 5 years ago

Just following up here, did we ultimately decide the best approach would be to require users to pass their Pass in when creating their Context? :) A lateral Pass pass?

Yeah I will give that another spin.