search

JuliaLabs / Cassette.jl

Overdub Your Julia Code
Other
371 stars 35 forks source link

Don't define overdub and recurse with eval #169

Closed MasonProtter closed 4 years ago

MasonProtter commented 4 years ago

Lets see if we still need to define these with eval.

MasonProtter commented 4 years ago

Okay, so the @pass test was failing because the arguments of overdub are no longer a gensym bound to OVERDUB_ARGUMENTS_NAME but instead just args....

I feel like there's a better way to safely implement pass overloading than this, but until that's decided maybe this shouldn't be merged because there could be hygiene issues in passes? Not really sure.