Handle `_apply_iterate` handling, but disable overdubbing of `iterf` in `_apply_iterate`

JuliaLabs / Cassette.jl

Overdub Your Julia Code

Other

371 stars 35 forks source link

Handle `_apply_iterate` handling, but disable overdubbing of `iterf` in `_apply_iterate` #172

Closed vchuravy closed 4 years ago

Roger-luo commented 4 years ago

@oxinabox I feel this solves https://github.com/oxinabox/AutoPreallocation.jl/issues/17 ? it seems apply_iterate was not handled correctly there?

vchuravy commented 4 years ago

Yeah the VACtx test stumped me. So I disabled overdubbing of iterf for now. There are still two other regressions, but at least this should unbreak Cassette on 1.4

KristofferC commented 4 years ago

Wasn't the whole point of introducing apply_iterate to be able to overdub the iterate in Core.apply?

vchuravy commented 4 years ago

Yes, this PR doesn't address that, but it correctly deals with apply_iterate in all other situations and returns the status quo for Cassette to 1.4.

Activating the overdubbing of iterate breaks more things so that requires another look.