Check for keyword function names differently on 1.4+

JuliaLabs / Cassette.jl

Overdub Your Julia Code

Other

371 stars 35 forks source link

Check for keyword function names differently on 1.4+ #173

Closed christopher-dG closed 4 years ago

christopher-dG commented 4 years ago

In https://github.com/christopher-dG/SimpleMock.jl/pull/11 I found that the names of keyword wrapper functions follow a different scheme starting with Julia 1.4. I think we can apply the same thing here!

I was hoping that this change would make the Skipped workaround in the above PR unnecessary, but that doesn't seem to be the case. I'll probably come up with a good MWE and open a new issue about that later.

Closes #161

vchuravy commented 4 years ago

Thanks! Would be great to also have a test.

christopher-dG commented 4 years ago

Lol turns out I botched the last commit -- I put kw## instead of ##kw. This does fix my SimpleMock issue and one of the Cassette tests!

vchuravy commented 4 years ago

Fantastic!