search

JuliaLabs / Cassette.jl

Overdub Your Julia Code
Other
371 stars 35 forks source link

fix on nightly #182

Closed simeonschaub closed 3 years ago

simeonschaub commented 3 years ago

Together with https://github.com/JuliaLang/julia/pull/39112, this fixes all but the ApplyCtx test for me locally and I think that one is either a wrong usage of Core._apply or a Julia bug. fixes #178

codecov-io commented 3 years ago

Codecov Report

Merging #182 (e3da4b9) into master (e22235a) will decrease coverage by 0.71%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   84.24%   83.53%   -0.72%     
==========================================
  Files           6        6              
  Lines         692      650      -42     
==========================================
- Hits          583      543      -40     
+ Misses        109      107       -2
Impacted Files Coverage Δ
src/overdub.jl 96.91% <100.00%> (+0.97%) :arrow_up:
src/context.jl 76.81% <0.00%> (-8.70%) :arrow_down:
src/tagging.jl 70.50% <0.00%> (-0.98%) :arrow_down:
src/pass.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e22235a...e3da4b9. Read the comment docs.

simeonschaub commented 3 years ago

Ok, looks like the latest nightlies already propagated through. Could I get a review?

vchuravy commented 3 years ago

Fantastic! Thank you :)

MasonProtter commented 3 years ago

Can we register a new version?