search

JuliaLabs / Cassette.jl

Overdub Your Julia Code
Other
371 stars 35 forks source link

better stacktraces in overdubs #186

Closed simeonschaub closed 3 years ago

simeonschaub commented 3 years ago

This fools Julia into thinking we inlined an additional function here, so we get better stacktraces. fixes #185

codecov-io commented 3 years ago

Codecov Report

Merging #186 (ae7eaca) into master (7ec499b) will increase coverage by 0.01%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   84.81%   84.83%   +0.01%     
==========================================
  Files           6        6              
  Lines         731      745      +14     
==========================================
+ Hits          620      632      +12     
- Misses        111      113       +2
Impacted Files Coverage Δ
src/overdub.jl 95.94% <93.75%> (-0.49%) :arrow_down:
src/tagging.jl 72.00% <0.00%> (-0.40%) :arrow_down:
src/Cassette.jl 100.00% <0.00%> (ø)
src/context.jl 88.00% <0.00%> (+1.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ec499b...ae7eaca. Read the comment docs.

vchuravy commented 3 years ago

Exciting! Is there a testcase we could construct?

simeonschaub commented 3 years ago

Yes, shouldn't be hard to add a proper test. Will add that