update for 1.10 - Githubissues

oscardssmith commented 1 year ago

https://github.com/JuliaLang/julia/pull/48766 makes it so retrieve_code_info takes in a worldage, and dramatically simplifies construction of .

oxinabox commented 1 year ago

Also needs to actually define an overload of __overdub_generator__ which accepts a world-age etc.

oscardssmith commented 1 year ago

This still has 1 erroring test and 2 failing but that predates this PR. 1.10 now works as well as 1.9.

oxinabox commented 1 year ago

Can we mark those tests as broken so we can merge this?

They don't look important, but I am not sure.

oscardssmith commented 1 year ago

I figure they're not that important given that they're also broken in Julia 1.9

oscardssmith commented 1 year ago

Unfortunately the errors on 1.9 were actually hiding errors that were happening later on in the code. commit incoming.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 11.11% and project coverage change: -4.15% :warning:

Comparison is base (fae23e7) 85.38% compared to head (c7a62c3) 81.24%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #205 +/- ## ========================================== - Coverage 85.38% 81.24% -4.15% ========================================== Files 6 6 Lines 787 773 -14 ========================================== - Hits 672 628 -44 - Misses 115 145 +30 ``` | [Files Changed](https://app.codecov.io/gh/JuliaLabs/Cassette.jl/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLabs) | Coverage Δ | | |---|---|---| | [src/overdub.jl](https://app.codecov.io/gh/JuliaLabs/Cassette.jl/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLabs#diff-c3JjL292ZXJkdWIuamw=) | `86.16% <11.11%> (-6.98%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/JuliaLabs/Cassette.jl/pull/205/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oxinabox commented 1 year ago

Looking at the last 2 failures. It looks like they both should be handled with:

if VERSION>v"1.9"
    @test ...
else
   @test ...

because I think both old and new answer is correct and it just represents a nonsemantic change in the internals. The numbers are all the same. just the addition of a core._apply operation.

oscardssmith commented 1 year ago

Good call. All 1.6 and 1.9 tests are now passing. I believe this is ready to merge.

JuliaLabs / Cassette.jl

update for 1.10 #205

Codecov Report