search

JuliaLabs / Cassette.jl

Overdub Your Julia Code
Other
371 stars 35 forks source link

remove show on the generated context type #206

Closed KristofferC closed 9 months ago

KristofferC commented 11 months ago

This causes catastrofic invalidations and cannot really be worth it

As a demonstration:

Screenshot 2023-11-17 at 13 50 10

Here, FunctionProperties.jl uses @context and immediately causes 12k invalidations (can be seen by looking at the invalidation plot).

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5fe09b7) 82.92% compared to head (e483e92) 82.90%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #206 +/- ## ========================================== - Coverage 82.92% 82.90% -0.03% ========================================== Files 6 6 Lines 814 813 -1 ========================================== - Hits 675 674 -1 Misses 139 139 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.