Closed jumerckx closed 9 months ago
Btw we could just name it Module
instead of MModule
.
Could you also add a test?
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
3fd9f2e
) 3.07% compared to head (796a6e1
) 1.89%.
Files | Patch % | Lines |
---|---|---|
src/IR/IR.jl | 55.55% | 4 Missing :warning: |
src/IR/Support.jl | 0.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I renamed MModule
to Module
and added tests, are they thorough enough?
Not sure how to get rid of: WARNING: using IR.Module in module Main conflicts with an existing identifier.
Are we doing a using LLVM
?
IIRC, I first called it MModule
since otherwise it conflicted with Base.Module
which is exported by Base
and therefore Module
was always ambiguous unless qualified.
We could do as LLVM and not export it:
julia> Base.isexported(LLVM, :Module)
false
Thanks, not exporting does the trick.
I opened https://github.com/JuliaLang/julia/pull/53162 to allow doing:
using MLIR.IR: Module
This enables creating modules with attributes such as: