JuliaLabs / ShallowWaterBench

Other
8 stars 6 forks source link

shallow_water.jl #10

Closed fxgiraldo closed 5 years ago

fxgiraldo commented 5 years ago

Hey guys, the shallow water looks pretty cool. One comment: you shouldn't need line 131. If I understand correctly, you are reimposing U=h*u but you have already evolved U in time correctly.

willow-ahrens commented 5 years ago

Thanks for the tip! I think I may have included that line because it was in the original shallow_water, but since it's not necessary I can remove it.