JuliaLabs / ShallowWaterBench

Other
8 stars 6 forks source link

Handling of unstructured meshes #6

Open jkozdon opened 5 years ago

jkozdon commented 5 years ago

Great to see you all working on the code! Excited to see what you come up with. Feel free to contact any of us (@lcw, @fxgiraldo, @jkozdon) directly if you want to talk through anything or have questions about what the code is (or needs to do).

For the mesh stuff, I wanted to make sure that you knew that the periodic Cartesian case is not the only case we care about. At the end of the day, we will need to handle unstructured meshes and boundary conditions.

One of the things that I didn't see when looking at what you've been doing is an orientation code. Namely, elements need to know if they are rotated with respect to a neighbors face. In 2-D, if you guarantee all your elements are right or left-handed I think you can get away without an orientation code, but in 3-D it is required for an unstructured mesh. Also, in 2-D an orientation maybe required for meshes like the cube sphere, and I don't know if all mesh generators guarantee one type of element over another for shell type meshes.