JuliaLang / AllocCheck.jl

AllocCheck
Other
209 stars 8 forks source link

Split errors into `AllocationSite`, `AllocatingRuntimeCall`, and `DynamicDispatch` #36

Closed topolarity closed 8 months ago

topolarity commented 8 months ago

This makes it much easier to understand the three main opponents one will have when trying to eliminate allocations.

This also does a major re-factoring of the allocfunc.jl internals while we're at it.

Example: image

gbaraldi commented 8 months ago

Should we call them errors or something else? And maybe we should add an option to the macro so it executes anyway? But prints this as a warning?

topolarity commented 8 months ago

Should we call them errors or something else?

Open to suggestions 🙂

And maybe we should add an option to the macro so it executes anyway? But prints this as a warning?

I'd be open to a warn_only option or similar, yeah

gbaraldi commented 8 months ago

I guess errors are fine. They look like errors, so I guess that sets the expectation

topolarity commented 8 months ago

Time to go public 😎